fix: Run "Reorder models" on copy of array to prevent side effects

The models array on the parent component was implicitly modified, which
could lead to an incorrect model order if the dialog was closed without saving.

frontend/src/app/projects/project-detail/model-overview/reorder-models-dialog/reorder-models-dialog.component.html

@@ -17,7 +17,7 @@ <h2>Reorder models</h2>
     (cdkDropListDropped)="drop($event)"
     class="my-[15px] rounded border border-solid"
   >
-    @for (model of data.models; track model.id) {
+    @for (model of models; track model.id) {
       <div
         cdkDrag
         class="flex cursor-move items-center border-b border-solid bg-white"

frontend/src/app/projects/project-detail/model-overview/reorder-models-dialog/reorder-models-dialog.component.ts

@@ -27,14 +27,20 @@ export class ReorderModelsDialogComponent {
     private toastService: ToastService,
     @Inject(MAT_DIALOG_DATA)
     public data: { projectSlug: string; models: Model[] },
-  ) {}
+  ) {
+    this.models = [...data.models];
+  }
+
+  models?: Model[] = undefined;
 
   drop(event: CdkDragDrop<Model[]>): void {
-    moveItemInArray(this.data.models, event.previousIndex, event.currentIndex);
+    if (this.models === undefined) return;
+    moveItemInArray(this.models, event.previousIndex, event.currentIndex);
   }
 
   async reorderModels() {
-    const modelsToPatch = this.data.models.map((model, index) => {
+    if (this.models === undefined) return;
+    const modelsToPatch = this.models.map((model, index) => {
       return {
         modelSlug: model.slug,
         patchModel: { display_order: index + 1 },