Merge pull request #1949 from DSD-DBS/longer-feedback

fix: Allow longer feedback and warn users if their feedback is too long
DSD-DBS · Nov 4, 2024 · 76136c0 · 76136c0
2 parents 633bcff + ab801d7
commit 76136c0
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/backend/capellacollab/feedback/models.py b/backend/capellacollab/feedback/models.py
@@ -65,7 +65,7 @@ class Feedback(core_pydantic.BaseModel):
         description="The rating of the feedback"
     )
     feedback_text: str | None = pydantic.Field(
-        description="The feedback text", max_length=255
+        description="The feedback text", max_length=500
     )
     share_contact: bool = pydantic.Field(
         description="Whether the user wants to share their contact information"

diff --git a/frontend/src/app/sessions/feedback/feedback-dialog/feedback-dialog.component.html b/frontend/src/app/sessions/feedback/feedback-dialog/feedback-dialog.component.html
@@ -60,6 +60,11 @@ <h1 class="text-lg font-semibold">
           formControlName="feedbackText"
           data-testid="feedback-text"
         ></textarea>
+        @if (feedbackForm.controls.feedbackText.hasError("maxlength")) {
+          <mat-error>
+            Your feedback can't be longer than 500 characters.
+          </mat-error>
+        }
         <mat-hint
           >Try to be specific. What happened? What were you doing?</mat-hint
         >

diff --git a/frontend/src/app/sessions/feedback/feedback-dialog/feedback-dialog.component.ts b/frontend/src/app/sessions/feedback/feedback-dialog/feedback-dialog.component.ts
@@ -64,7 +64,9 @@ export class FeedbackDialogComponent {
       undefined,
       Validators.required,
     ),
-    feedbackText: new FormControl<string>(''),
+    feedbackText: new FormControl<string>('', {
+      validators: [Validators.maxLength(500)],
+    }),
     shareContact: new FormControl<boolean>(true),
   });