fix: use model ids in place of names and rename patch function

DSD-DBS · Dec 6, 2023 · 354e249 · 354e249
1 parent 453f954
commit 354e249
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/frontend/src/app/projects/models/service/model.service.ts b/frontend/src/app/projects/models/service/model.service.ts
@@ -92,7 +92,7 @@ export class ModelService {
       );
   }
 
-  private patchModel(
+  private applyModelPatch(
     projectSlug: string,
     modelSlug: string,
     patchData: PatchModel,
@@ -108,7 +108,7 @@ export class ModelService {
     modelSlug: string,
     patchModel: PatchModel,
   ): Observable<Model> {
-    return this.patchModel(projectSlug, modelSlug, patchModel).pipe(
+    return this.applyModelPatch(projectSlug, modelSlug, patchModel).pipe(
       tap({
         next: (model) => {
           this.loadModels(projectSlug);
@@ -123,7 +123,7 @@ export class ModelService {
     modelUpdates: { modelSlug: string; patchModel: PatchModel }[],
   ): Observable<Model[]> {
     const updateObservables = modelUpdates.map(({ modelSlug, patchModel }) =>
-      this.patchModel(projectSlug, modelSlug, patchModel),
+      this.applyModelPatch(projectSlug, modelSlug, patchModel),
     );
 
     return forkJoin(updateObservables).pipe(

diff --git a/.../project-detail/model-overview/reorder-models-dialog/reorder-models-dialog.component.html b/.../project-detail/model-overview/reorder-models-dialog/reorder-models-dialog.component.html
@@ -17,7 +17,7 @@ <h2>Reorder models</h2>
     (cdkDropListDropped)="drop($event)"
     class="my-[15px] rounded border border-solid"
   >
-    @for (model of data.models; track model.name) {
+    @for (model of data.models; track model.id) {
       <div cdkDrag class="flex items-center border-b border-solid">
         <span class="ml-[10px]">
           <mat-icon class="mt-[10px] text-sm">reorder</mat-icon>