Run Unit tests for all branches again #2867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing 1 of the deprecations
We limited because of the number of minutes but as we're close to migrating away from GitLab this is the easier fix for the current deprecation issue.
vmcj
force-pushed
the
unit_deprecation
branch
2 times, most recently
from
904972c to
acea30d
Compare
Before the failure was overwritten when the unit tests passed, now we correctly fail instead of only having an visual indicator. Also display the PHP version used for the deprecations, this makes debugging easier.
Also pin to the second to last released version for the GHA as the last one crashes.
vmcj
force-pushed
the
unit_deprecation
branch
from
ecdbd47 to
63c53db
Compare
nickygerritsen
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We limited because of the number of minutes but as we're close to migrating away from GitLab this is the easier fix for the current deprecation issue.
This does still not explain why some pushes to main trigger the failing job and some don't but I hope we get the result a bit earlier.