Allow setting external contest source with contest.yaml #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -251,6 +252,23 @@ public function importContestData(mixed $data, ?string &$errorMessage = null, st | |||
| } | |||
|
|
|||
| $this->em->persist($contest); | |||
|
|
|||
| $shadow_type = $data['shadow_type'] ?? null; | |||
There was a problem hiding this comment.
We should document that you can do this whole thing
There was a problem hiding this comment.
Makes sense, although the only users using this are us IMO.
There was a problem hiding this comment.
Which I agree with but I don't want to check the code to see how the fields are called. Also, maybe we use a subkey?
shadow:
type: xxxetc?
Also makes the code more readable.
vmcj
force-pushed
the
contest_shadow_config
branch
from
6fb24ff to
ee0f25a
Compare
nickygerritsen
approved these changes
Nov 7, 2023
Useful for mostly us but documented in the manual. Doing this in the API doc is non trivial for now. Co-authored-by: Nicky Gerritsen <[email protected]>
vmcj
force-pushed
the
contest_shadow_config
branch
from
9335b5d to
1fb4acc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to setup the analyst instance during the finals.
I've done it so that we only overwrite the fields if explicit set so it is possible to remove the password from the contest and not remove it when someone updates the contest again to alter the time for example.
Closes: #2179