Extend setup database create dump #2184
Conversation
|
I don't think that taking parts out of #2180 helps: now all the comments are lost and it's more difficult to track what's going on where. |
Those should be all the handled parts (and only the simple command). I think the last remarks were about the behaviour of loading the dump and that seems to be a discussion on itself (but can take place in the other PR). But if you still find issues with this PR I'm fine with handling it within the other one but for me it's a lot harder if I need to handle multiple things and keep on testing. |
vmcj
force-pushed
the
extend_setup_database_create_dump
branch
from
ea42be8 to
ab77a17
Compare
|
@eldering as discussed yesterday, I prefer to already merge this part and then address the last issues on the |
vmcj
force-pushed
the
extend_setup_database_create_dump
branch
from
ab77a17 to
51bb554
Compare
Small alignment fixes for the next commit where a new option will be added.
vmcj
force-pushed
the
extend_setup_database_create_dump
branch
from
5958ce3 to
dd7ec15
Compare
Loosely copied from the domjudge-scripts repo. This does remove the prefix question as just exiting and letting the user reword less restrictive.
vmcj
force-pushed
the
extend_setup_database_create_dump
branch
from
dd7ec15 to
87a7286
Compare
This is the first half of #2180 but due to the amount of comments and needed tests I prefer to already merge the good parts.
This should create the same structure as the file we already had so together with
load-dbfrom the scripts repo this should work.