Suggested partial fix for splitting installation process #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
force-pushed
the
20230509_split_configure
branch
from
377bcdd to
3affd5f
Compare
eldering
reviewed
Jun 6, 2023
|
I'll work on this again in the future but we need some extra tests for this before I'm confident that we can work on this. |
vmcj
force-pushed
the
20230509_split_configure
branch
3 times, most recently
from
f0df561 to
6be7f4a
Compare
nickygerritsen
changed the title
eldering
approved these changes
Nov 24, 2023
vmcj
force-pushed
the
20230509_split_configure
branch
from
6be7f4a to
7ace1cf
Compare
The default configure will still configure both the judgehost & domserver. New is that we now disable checks if you remove the domserver/judgehost section with --disable-domserver-build. Nothing limits a user from running configure without the required settings for the domserver (--disable-domserver-build), this detects this and warns the user as this would now be an poorly tested state. The code only fills variables those with possible defaults but as we might skip crucial steps either before or after it is better to leave those blank and make this easier to spot.
It is not needed for demonstration and somehow fedora can't find the libraries. This is something which should be check independant from this PR.
vmcj
force-pushed
the
20230509_split_configure
branch
from
7ace1cf to
2527944
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried the suggestion of @eldering (#862 (comment)) as I think that is the correct solution. It gave some non trivial problems which given my experience with autoconf were difficult to solve.
This should already be a start to annotate what can be moved to other
autoconffiles and might even by a temporary fix to make everything work as expected. So even if we merge this I think we should leave the issue open as debt.