Skip to content

Commit

Permalink
Fail integration test on any PHP/Framwork Exception
Browse files Browse the repository at this point in the history
In the past we only did this for warnings in the prod env but those
shouldn't happen regardless of if we run those in `dev`, `test` or `prod`.

This hopefully protects future tests where we miss this line.
  • Loading branch information
vmcj committed Dec 7, 2024
1 parent a2e90da commit 4043836
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,10 @@ jobs:
curl $CURLOPTS http://localhost/domjudge/jury/contests/1/freeze/doNow || true
curl $CURLOPTS http://localhost/domjudge/jury/contests/1/end/doNow || true
curl $CURLOPTS -X POST -d 'finalize_contest[b]=0&finalize_contest[finalizecomment]=gitlab&finalize_contest[finalize]=' http://localhost/domjudge/jury/contests/1/finalize
- name: Verify no errors in prod.log
- name: Verify no errors in symfony {prod,test,dev}.log
shell: bash
run: |
if cat /opt/domjudge/domserver/webapp/var/log/prod.log | egrep '(CRITICAL|ERROR):'; then
if cat /opt/domjudge/domserver/webapp/var/log/*.log | egrep '(CRITICAL|ERROR):'; then
exit 1
fi
- name: Download and perform API check
Expand Down

0 comments on commit 4043836

Please sign in to comment.