Skip to content

Commit

Permalink
Don't make all table cells fully clickable
Browse files Browse the repository at this point in the history
The intent in 122c545 was to align
everything properly but the audit table has a mix of cells with text and
with anchors. We either have to set some extra conditions on the `td` or
just not use the new logic for certain tables.
  • Loading branch information
vmcj committed Nov 6, 2023
1 parent 80e568c commit 2caea0b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion webapp/src/Controller/Jury/AuditLogController.php
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public function indexAction(
return $this->render('jury/auditlog.html.twig', [
'auditlog' => $auditlog_table,
'table_fields' => $table_fields,
'table_options' => ['ordering' => 'false', 'searching' => 'false'],
'table_options' => ['ordering' => 'false', 'searching' => 'false', 'full_clickable' => false],
'maxPages' => $maxPages,
'thisPage' => $thisPage,
'showAll' => $showAll,
Expand Down
4 changes: 2 additions & 2 deletions webapp/templates/jury/jury_macros.twig
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@
{% endmacro %}

{% macro table(data, fields, options) %}

<div class="table-wrapper">
<table class="data-table table table-sm table-striped table-full-clickable-cell" style="width:auto">
<table style="width:auto" class="data-table table table-sm table-striped
{% if options.full_clickable is defined and options.full_clickable %}table-full-clickable-cell{% endif %}">
<thead class="">
<tr>
{%- set num_actions = data | numTableActions %}
Expand Down

0 comments on commit 2caea0b

Please sign in to comment.