-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small reorderings #199
Open
vmcj
wants to merge
4
commits into
DOMjudge:main
Choose a base branch
from
vmcj:small_reorderings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Small reorderings #199
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,10 @@ LABEL org.opencontainers.image.authors="DOMjudge team <[email protected]>" | |
|
||
ENV DEBIAN_FRONTEND=noninteractive | ||
|
||
# Set up user | ||
RUN groupadd domjudge -g2004 | ||
RUN useradd -m domjudge -u2004 -g2004 | ||
|
||
# Install required packages for build of domserver | ||
RUN apt-get update \ | ||
&& apt-get install --no-install-recommends --no-install-suggests -y \ | ||
|
@@ -22,9 +26,6 @@ RUN apt-get update \ | |
# Use venv to install latest Sphinx. 6.1.0 or higher is required to build DOMjudge docs. | ||
RUN python3 -m venv /venv && . /venv/bin/activate && pip3 install sphinx sphinx-rtd-theme rst2pdf | ||
|
||
# Set up user | ||
RUN useradd -m domjudge | ||
|
||
# Install composer | ||
RUN php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');" \ | ||
&& php composer-setup.php \ | ||
|
@@ -58,18 +59,13 @@ RUN useradd -m domjudge | |
RUN apt-get update \ | ||
&& apt-get install --no-install-recommends --no-install-suggests -y \ | ||
acl curl zip unzip supervisor mariadb-client apache2-utils \ | ||
nginx php-cli php-fpm php-zip \ | ||
nginx php-cli php-fpm php-zip composer \ | ||
php-gd php-curl php-mysql php-json php-intl \ | ||
php-gmp php-xml php-mbstring php-ldap \ | ||
enscript lpr \ | ||
ca-certificates python3-yaml python3-requests \ | ||
&& rm -rf /var/lib/apt/lists/* | ||
|
||
# Install composer | ||
RUN php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');" \ | ||
&& php composer-setup.php \ | ||
&& mv /composer.phar /usr/local/bin/composer | ||
|
||
# Copy domserver | ||
COPY --from=domserver-build /opt/domjudge/domserver /opt/domjudge/domserver | ||
COPY --from=domserver-build /opt/domjudge/doc /opt/domjudge/doc | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,28 +3,23 @@ LABEL org.opencontainers.image.authors="DOMjudge team <[email protected]>" | |
|
||
ENV DEBIAN_FRONTEND=noninteractive | ||
|
||
# Set up user | ||
RUN groupadd domjudge -g2004 | ||
RUN useradd -m domjudge -u2004 -g2004 | ||
|
||
# Install required packages for build of judgehost | ||
RUN apt-get update \ | ||
&& apt-get install --no-install-recommends --no-install-suggests -y \ | ||
autoconf automake git pkg-config \ | ||
gcc g++ make zip unzip \ | ||
php-cli php-zip lsb-release debootstrap \ | ||
php-gd php-curl php-mysql php-json \ | ||
php-gmp php-xml php-mbstring \ | ||
php-gmp php-xml php-mbstring composer \ | ||
sudo bsdmainutils ntp libcgroup-dev procps \ | ||
libcurl4-gnutls-dev libjsoncpp-dev libmagic-dev \ | ||
ca-certificates \ | ||
&& rm -rf /var/lib/apt/lists/* | ||
|
||
# Set up user | ||
RUN useradd -m domjudge | ||
|
||
# Install composer | ||
|
||
RUN php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');" \ | ||
&& php composer-setup.php \ | ||
&& mv /composer.phar /usr/local/bin/composer | ||
|
||
# Add DOMjudge source code and build script | ||
ADD domjudge.tar.gz /domjudge-src | ||
ADD judgehost/build.sh /domjudge-src | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a draft in branch queue/check-ownership-across-docker-build-stages (f62e173) to check the UID & GID are the same instead of having to hard-code the values.