DNS-over-HTTP support, making TLS optional #2729
Open
+8
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are many situations where DNSCrypt-proxy can run under the reverse TLS proxy. In that case, built-in DNSCrypt-proxy TLS server becomes redundant.
Solution
If the certificate and key are empty strings, instead of erroring out, start a server without TLS. Just pure HTTP.
Example
You can configure nginx like this:
And
dnscrypt-proxy.toml
like this:To get TLS from Nginx instead of dnscrypt-proxy.
Trivia
Tested this patch on my server, everything works just as I intended. Hopefully this will make a fine addition to this project :)