Enhancements #42
Merged
Enhancements #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a user name, and try different passwords in case the service has rules about password restrictions
…esn't contain bogus data
|
I reviewed and tested. LGTM |
|
Approved 5/14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #41 (depends on updating redfish_utilities to 1.0.6)
Fix #39 (added logic to try different passwords to address password complexity requirements)
Fix #36 (added step in test to not assume the account needs an explicit PATCH to Enabled)
Partially addresses #37 (at least for account management, the only hole I found was if the test failed to PATCH the account to be Enabled, it will end the test without deleting the user that was created)
Also added a new check in the power/thermal test to verify sensors do not have bogus readings (such as if a device is not present, but there is still a reading being provided).