Merge pull request #3441 from DMPRoadmap/plan-deep-copy-bug-copies-ol…

…d-id-as-identifier

Fix for bug in Plan duplication results in original plan identifier b…

CHANGELOG.md

@@ -1,10 +1,8 @@
 # Changelog
 
-## v4.2.1
-
-### Fixed
+- Fixed a bug in the deep copy of plans where the old identifier was being copied into the new plan. We now copy the generated id of the new plan to the identifier field.
 - Fixed bar chart click function in the Usage dashboard (GitHub issue #3443)
-## v4.2.0
+
 
 **Note this upgrade is mainly a migration from Bootstrap 3 to Bootstrap 5.** 
 

app/models/plan.rb

@@ -255,6 +255,9 @@ def self.deep_copy(plan)
     plan_copy.title = "Copy of #{plan.title}"
     plan_copy.feedback_requested = false
     plan_copy.save!
+    # Copy newly generated Id to the identifier
+    plan_copy.identifier = plan_copy.id.to_s
+    plan.save!
     plan.answers.each do |answer|
       answer_copy = Answer.deep_copy(answer)
       answer_copy.plan_id = plan_copy.id