-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: adding integration tests #210
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fstagni
changed the title
test: added an integration test
test: adding integration tests
Oct 3, 2023
fstagni
force-pushed
the
int_test
branch
14 times, most recently
from
October 4, 2023 12:32
e824915
to
0483c3d
Compare
fstagni
force-pushed
the
int_test
branch
8 times, most recently
from
October 5, 2023 10:46
48b9efe
to
fa8a684
Compare
fstagni
force-pushed
the
int_test
branch
6 times, most recently
from
October 6, 2023 13:57
2d48e78
to
88bf997
Compare
3 tasks
Thanks for these tests. As CTA for now we don't have any pilot extension. |
Thanks for the info. What is the full command to start CTA pilots? To see if these tests cover you case. |
I merge this, I see nothing wrong with it. No review, as usual for my PRs, can't wait forever. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds few integration test for the pilot:
HEAD
ofrel-v8r0
andintegration
branches of DIRAC. More variables to this matrix can be added, if felt requested.These tests are only run on "push", so not in the pull requests (for a reason that I ignore, the base64 encoded certs used here are not properly passed in the environment of github actions runners for PRs). The tests ran on my fork: https://github.com/fstagni/Pilot/actions/workflows/integration.yml (after adding the correct secrets...).
The tests for LHCb are just an example. If you have your own Pilot extension, those specific tests can be added here: cc @sfayer @hmiyake @arrabito