Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

fix(conditional-os): Add the correct conditional for os #17

Merged
merged 2 commits into from
Oct 29, 2020

Conversation

bertearazvan
Copy link
Contributor

@bertearazvan bertearazvan commented Oct 28, 2020

While this might not fix #16 , it's a step forward 👍🏻

@bertearazvan bertearazvan requested a review from rihr October 28, 2020 13:57
@bertearazvan bertearazvan added the bug Something isn't working label Oct 28, 2020
@rihr
Copy link

rihr commented Oct 28, 2020

I'm still getting the same result as in #16 . Does it fix the issue you mentioned with Windows?

@bertearazvan
Copy link
Contributor Author

When using yarn link and then using dhi-gras-boilerplate test it works for me to bootstrap the app on my local win10.

@bertearazvan
Copy link
Contributor Author

But to answer the question, no, this PR should not fix that issue, it's only something I noticed when I looked through it.

@bertearazvan bertearazvan merged commit be02995 into master Oct 29, 2020
@bertearazvan
Copy link
Contributor Author

🎉 This PR is included in version 1.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants