-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows tick events to auto-requeue when registered as listeners #2484
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after this change, what will the options be for cpp and lua code to handle regular callbacks? will we be able to replace repeat-util
with eventful
?
It looks as though that script could easily be replaced, yes. edit: As for options, cpp will have the eventful on the other hand, doesn't have tick events integrated.. but shouldn't be difficult to do. edit2: So I've tried to integrate tick events to eventful. It needs a bit of testing, but I believe it has all the same boilerplate the other event types have (so it should work, unless I missed something). It will only rely on the |
ca0ebb9
to
372c345
Compare
- converts `freq` and `eventHandler` (i.e. the callback) to `const` - removes the non-const `when` from the hash computation
1a4914b
to
e2bc986
Compare
As discussed on discord, there are a few technical challenges when bringing tick events to lua. So I reverted those changes. I've included an updated channel-safely in this PR which uses the newly repeating tick events to perform some tasks. Additionally I had added a temporary event which repeated hourly and performed a test to ensure the tick listener events are refiring without any user effort. [test was successful] |
No description provided.