Block invalid policy combinations #3474
Open
+189
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjlynch
force-pushed
the
CAPT-2078/prevent-invalid-policy-combos
branch
from
fa4e1a9 to
ba4561c
Compare
rjlynch
force-pushed
the
CAPT-2078/prevent-invalid-policy-combos
branch
from
ba4561c to
8a968ac
Compare
rjlynch
force-pushed
the
CAPT-2078/prevent-invalid-policy-combos
branch
from
8a968ac to
bcfc533
Compare
rjlynch
force-pushed
the
CAPT-2078/prevent-invalid-policy-combos
branch
from
bcfc533 to
873157f
Compare
rjlynch
force-pushed
the
CAPT-2078/prevent-invalid-policy-combos
branch
from
873157f to
328e296
Compare
kenfodder
reviewed
Dec 23, 2024
rjlynch
force-pushed
the
CAPT-2078/prevent-invalid-policy-combos
branch
3 times, most recently
from
3c2c709 to
4ed4605
Compare
kenfodder
approved these changes
Dec 23, 2024
The business rules state that certain policy combinations aren't permitted, eg if a claimant has made an ECP claim they can't make a second claim for FE in the same academic year. In such an invalid claim scenario the requirement is to disable the approve button so admins can't approve the claim.
rjlynch
force-pushed
the
CAPT-2078/prevent-invalid-policy-combos
branch
from
4ed4605 to
278d3d7
Compare
While it requires twice as many elements to check were not working with that many and using permutation avoids needed to ensure the list is sorted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The business rules state that certain policy combinations aren't
permitted, eg if a claimant has made an ECP claim they can't make a
second claim for FE in the same academic year. In such an invalid claim
scenario the requirement is to disable the approve button so admins
can't approve the claim.