-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CAPT-2051] Better OL name #3454
base: master
Are you sure you want to change the base?
Conversation
3a5646b
to
45e400f
Compare
45e400f
to
429c5b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively we could consider keeping the separate first name and last name fields, but concatenating the name parts for GivenName
and FamilyName
types, rather than only selecting the first of each
@@ -21,6 +21,10 @@ def date_of_birth | |||
Date.parse(decoded_jwt[0]["vc"]["credentialSubject"]["birthDate"][0]["value"]) | |||
end | |||
|
|||
def full_name | |||
name_parts.map { |hash| hash["value"] }.join(" ") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we ensure that the FamilyName
part(s) are always last? I suspect there's no guarantee it will be ordered this way already.
Context
Changes
onelogin_idv_full_name
is no longer a virtual attribute and returns the full name OL returnsonelogin_idv_full_name
with data we have which is concatenation of first and last nameNotes
onelogin_idv_first_name
andonelogin_idv_last_name
as these will become redundant