[RUBY-3387] Remove ids from do not copy attributes as id is automatic…

…ally ignored
DEFRA · Oct 18, 2024 · 411353f · 411353f
1 parent d0c38e3
commit 411353f
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 4 deletions.
diff --git a/app/models/waste_carriers_engine/past_registration.rb b/app/models/waste_carriers_engine/past_registration.rb
@@ -12,7 +12,6 @@ class PastRegistration
     embedded_in :registration, class_name: "WasteCarriersEngine::Registration"
 
     NON_COPYABLE_ATTRIBUTES = %w[
-      _id
       accountEmail
       past_registrations
       locking_name

diff --git a/app/models/waste_carriers_engine/renewing_registration.rb b/app/models/waste_carriers_engine/renewing_registration.rb
@@ -14,8 +14,7 @@ class RenewingRegistration < TransientRegistration
     field :from_magic_link, type: Boolean
 
     COPY_DATA_OPTIONS = {
-      ignorable_attributes: %w[_id
-                               accountEmail
+      ignorable_attributes: %w[accountEmail
                                constructionWaste
                                contactEmail
                                conviction_search_result

diff --git a/app/services/waste_carriers_engine/registration_completion_service.rb b/app/services/waste_carriers_engine/registration_completion_service.rb
@@ -127,7 +127,6 @@ def copy_data_from_transient_registration
       transient_registration.reload
 
       do_not_copy_attributes = %w[
-        _id
         conviction_search_result
         conviction_sign_offs
         created_at