SEMVER - (MINOR): Release 1.55.0 #2083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create activity in CRM https://eaflood.atlassian.net/browse/IWTF-4329 Create activity in CRM
* Licence summary licence type capitals https://eaflood.atlassian.net/browse/IWTF-4348 Licence type content on licence summary page has no capital letters * add caps
* Change links for three rod licence https://eaflood.atlassian.net/browse/IWTF-3785 Remove change link for changing length for three rod licences on summary page * hide change link for lenght for three rod licence * lint * remove changes from this branch * check only number of rods not type
* Set-output removed from versioning script https://eaflood.atlassian.net/browse/IWTF-3967 Update versioning script for removing set-ouput * update build.yml to no longer use set-output --------- Co-authored-by: Scott Dormand <[email protected]>
https://eaflood.atlassian.net/browse/IWTF-4261 If the request to prepare a payment is part of setting up a new recurring payment agreement, then the agreement_id should be included. I also renamed prepareRecurringPayment() to prepareRecurringPaymentAgreement() as I think this is slightly more accurate - it is setting up the agreement rather than the payment - and it initially threw me off when working out what needed to be changed. * Store agreementId in DynamoDb * Fix agreementId validation in schema * Resolve linting issue * Add arg to payment connector for API key usage * Add recurring payment arg to govuk-pay-service Also added a lot more tests (cribbed from the sendRecurringPayment() ones) as the existing ones are testing through the payment processor for some reason. * Use recurring flag in agreed handler Because we need to check the recurring status at this level now, we can also remove the status check from the payment processor. * Update rest of pay connector to toggle headers * Add recurring flag to getPaymentStatus in service * Add recurring arg when checking payment status in agreed handler * Add optional() to schema * Use agreementId in payment processor logic * Fix mocking * Remove unnecessary default
* Remove ftp functionality https://eaflood.atlassian.net/browse/IWTF-4278 Remove ftp functionality as package we use in fulfilment and pocl jobs (ssh2-sftp-client) has critical vulnerability * remove ssh2 sftp client * remove ssh2 sftp client and fix lint * remove reference * fix tests * fix tests and lint * update tests * refactor * refactor * update tests * refactor tests * s3spec * undefined token * rename file and undo removal of stores3 * rename file and undo removal of stores3 * add missing mock * Remove ssh2 mock * remove functionality from config * remove ftp reference ---------
* Remove ftp functionality https://eaflood.atlassian.net/browse/IWTF-4278 Remove ftp functionality as package we use in fulfilment and pocl jobs (ssh2-sftp-client) has critical vulnerability * remove ssh2 sftp client * remove ssh2 sftp client and fix lint * remove reference * fix tests * fix tests and lint * update tests * refactor * refactor * update tests * refactor tests * s3spec * undefined token * rename file and undo removal of stores3 * rename file and undo removal of stores3 * add missing mock * Remove ssh2 mock * Remove ftp image and build https://eaflood.atlassian.net/browse/IWTF-4279 remove any FTP images from our Docker config * remove functionality from config * remove ftp reference * remove extra line
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.