Add agreement_id to existing GOV.UK Pay request #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/IWTF-4261 If the request to prepare a payment is part of setting up a new recurring payment agreement, then the agreement_id should be included. I also renamed prepareRecurringPayment() to prepareRecurringPaymentAgreement() as I think this is slightly more accurate - it is setting up the agreement rather than the payment - and it initially threw me off when working out what needed to be changed.
irisfaraway
force-pushed
the
feature/iwtf-4261-agreementid
branch
from
429f57d to
992b7aa
Compare
Also added a lot more tests (cribbed from the sendRecurringPayment() ones) as the existing ones are testing through the payment processor for some reason.
Because we need to check the recurring status at this level now, we can also remove the status check from the payment processor.
jaucourt
requested changes
Nov 21, 2024
packages/gafl-webapp-service/src/handlers/__tests__/agreed-handler-recurring-payments.spec.js
Outdated
Show resolved
Hide resolved
jaucourt
requested changes
Nov 21, 2024
|
jaucourt
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/IWTF-4261
If the request to prepare a payment is part of setting up a new recurring payment agreement, then the agreement_id should be included.
I also renamed prepareRecurringPayment() to prepareRecurringPaymentAgreement() as I think this is slightly more accurate - it is setting up the agreement rather than the payment - and it initially threw me off when working out what needed to be changed.