Remove ftp functionality #2064
Merged
Remove ftp functionality #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/IWTF-4278 Remove ftp functionality as package we use in fulfilment and pocl jobs (ssh2-sftp-client) has critical vulnerability
irisfaraway
requested changes
Oct 15, 2024
packages/pocl-job/src/io/s3.js
Outdated
Comment on lines
51
to
56
| const dynamicsRecord = await salesApi.getTransactionFile(filename) | ||
| if (!dynamicsRecord || !DYNAMICS_IMPORT_STAGE.isAlreadyProcessed(dynamicsRecord.status.description)) { | ||
| await storeS3Metadata(file.ETag, filesize(file.Size), filename, file.Key, moment(new Date(file.LastModified))) | ||
| } else { | ||
| console.log(`${file.Key} is already processed, skipping`) | ||
| } |
There was a problem hiding this comment.
Not sure if we want to delete this and the storeS3Metadata function – I think this can still be used for other file uploads as well and we don't want to blow up the direct debit process. However if we do keep it then it might make sense to move that function out of a file called ftp-to-s3.js anyway.
jaucourt
approved these changes
Oct 25, 2024
irisfaraway
approved these changes
Oct 28, 2024
irisfaraway
approved these changes
Nov 5, 2024
jaucourt
requested changes
Nov 7, 2024
packages/pocl-job/src/config.js
Outdated
| '3des-cbc', | ||
| 'cast128-cbc' | ||
| ] | ||
|
|
||
| class Config { | ||
| _db | ||
| _ftp |
There was a problem hiding this comment.
I don't think this is needed anymore either, is it?
|
jaucourt
approved these changes
Nov 20, 2024
ScottDormand96
deleted the
feature/iwtf-4278-remove-ftp-functionality
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/IWTF-4278
Remove ftp functionality as package we use in fulfilment and pocl jobs (ssh2-sftp-client) has critical vulnerability