Recurring payment agreement page #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/IWTF-3666 Setup the agreement page for recurring payments
…t cost, update tests and change wording json file
jaucourt
requested changes
Dec 15, 2023
...ages/gafl-webapp-service/src/pages/recurring-payments/set-up-payment/__tests__/route.spec.js
Show resolved
Hide resolved
packages/gafl-webapp-service/src/pages/recurring-payments/set-up-payment/set-up-payment.njk
Outdated
Show resolved
Hide resolved
packages/gafl-webapp-service/src/processors/__tests__/licence-type-display.spec.js
Outdated
Show resolved
Hide resolved
packages/gafl-webapp-service/src/processors/__tests__/recurring-pay-reminder-display.spec.js
Outdated
Show resolved
Hide resolved
jaucourt
requested changes
Dec 20, 2023
| it.each([ | ||
| [displayPermissionPrice, Symbol('mock catalog'), Symbol('mock permission')], | ||
| [recurringLicenceTypeDisplay, Symbol('mock catalog'), Symbol('mock permission')], | ||
| [recurringPayReminderDisplay, Symbol('mock catalog'), Symbol('mock permission')] |
There was a problem hiding this comment.
Thanks for combining - however, if you look at your parameters the only thing that differs is the first one. So the other two are redundant and can be defined in the test.
| }) | ||
|
|
||
| it.each([[CHOOSE_PAYMENT.uri], [TERMS_AND_CONDITIONS.uri] | ||
| ])('addLanguageCodeToUri is called with permission and %s', async (uri) => { |
There was a problem hiding this comment.
Surprised lint didn't pick this up, but you don't need brackets around a single parameter (uri)
…me paramters permission/catalog
|
jaucourt
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/IWTF-3666
Setup the agreement page for recurring payments