Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove phone from content in text message option #1826

Merged

Conversation

ScottDormand96
Copy link
Collaborator

https://eaflood.atlassian.net/browse/IWTF-3861

Remove the word phone from the content for a text message option

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jaucourt jaucourt added the enhancement New feature or request label Nov 22, 2023
@ScottDormand96 ScottDormand96 merged commit 0c6b071 into develop Nov 23, 2023
4 checks passed
@ScottDormand96 ScottDormand96 deleted the feature/iwtf-3861-remove-phone-content-in-text branch November 23, 2023 08:52
ScottDormand96 added a commit that referenced this pull request Nov 27, 2023
* Remove phone from content in text message option

https://eaflood.atlassian.net/browse/IWTF-3861

Remove the word phone from the content for a text message option

* added welsh
ScottDormand96 added a commit that referenced this pull request Jan 3, 2024
* Feature branch rp job

* Initial setup RP job (#1769)

* Initial setup RP job

https://eaflood.atlassian.net/browse/IWTF-3381

Setup recurring payment job

* initial setup

* Update docker/README.md

Co-authored-by: Iris Faraway <[email protected]>

* update readme

* update license

* add console log for when rp running

* setup docker so picks up commands run tomprove running

* LICENSE

---------

Co-authored-by: Iris Faraway <[email protected]>

* Retrieve recurring payments

https://eaflood.atlassian.net/browse/IWTF-3617

Recurring Payments Job to retrieve the recurring payments due on the current day

* grab rp

* working rpjob

* update error in tranaction.schema

* prettier readme

* remove console logs

* Updated following comments in PR, pushing to fix test

* Update dependencies, fix lint errors

* push changes for support

* update getRecurringPayments

* updated env files, remove logs, add date, refactor tests

* lint errors

* code smells

* remove console logs

* fix broken test

* fix code smell

* remove await

* code coverage

* update tests and package.json

* npm install on rp job folder

* remove package-lock and run npm install

* update package-lock and package references

* changes made following pr comments

* update package.json

* update entity tests, add comments where changes are needed

* Amend so that we expand contact and active permission in a single fetc
h, plus filter just on date when retrieving recurring payments

* Fixed process transaction queue tests

* Fix recurring payment service tests

* Update dependencies

* Fix more dependencies

* Dependencies. Yeah.

* new version of recurring-payments-job

* Update package lock for recurring payments job

* Remove automock and add manual mock to work around weird failure

* Fix RP query test

* Fix code smell

* Remove phone from content in text message option (#1826)

* Remove phone from content in text message option

https://eaflood.atlassian.net/browse/IWTF-3861

Remove the word phone from the content for a text message option

* added welsh

* chore(release): publish v1.37.0-rc.7

* rename tests, change date format and update tests

* remove mockRestore

---------

Co-authored-by: Iris Faraway <[email protected]>
Co-authored-by: Phil Benson <[email protected]>
Co-authored-by: GitHub Actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants