Insert Google Tag Manager snippet in template #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/IWTF-3732 This PR adds the snippet for Google Tag Manager to the default layout. This snippet should only be inserted when the container ID is present.
jaucourt
requested changes
Oct 27, 2023
packages/gafl-webapp-service/src/handlers/__tests__/__snapshots__/page-handler.spec.js.snap
Outdated
Show resolved
Hide resolved
| {% block bodyStart %} | ||
| {% if gtmContainerId %} | ||
| <!-- Google Tag Manager (noscript) --> | ||
| <noscript><iframe src="https://www.googletagmanager.com/ns.html?id={{gtmContainerId}}" height="0" width="0" style="display:none;visibility:hidden"></iframe></noscript> |
There was a problem hiding this comment.
Tiny point, but we don't need visibility:hidden if there's already display:none
There was a problem hiding this comment.
This was the code Google provided so I'm wary of messing with it!
There was a problem hiding this comment.
Yeah, whoever wrote it doesn't understand CSS!
|
SonarCloud Quality Gate failed.
|
|
Ticket created to remove Hapi Gapi code: https://eaflood.atlassian.net/browse/IWTF-3843 |
jaucourt
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/IWTF-3732
This PR adds the snippet for Google Tag Manager to the default layout. This snippet should only be inserted when the container ID is present.