SEMVER - MINOR: Release 1.36.0 #1809
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/IWTF-3672 Remove back link from main content
This reverts commit 850df74.
…p-link-back-button Revert "Accessibility - back link"
* Upgrade to v 18 of node https://eaflood.atlassian.net/browse/IWTF-3625 Upgrade version of node to version 18.17 * upgrade node, fix test, upgrade node-sass * build.yml node v * package-lock develop conflicts
https://eaflood.atlassian.net/browse/IWTF-3672 Co-authored-by: ScottDormand96 <[email protected]>
This PR changes the Node image we are using to run 18.17 instead, as well as a minor tweak to the Python installation as a result of the new image.
https://eaflood.atlassian.net/browse/IWTF-3674 This change makes sure that the correct language tags are applied to the HTML depending on whether the page is in English or Welsh. It also adds attributes to the language switch links to make sure those are always tagged with the correct language.
* Accessibility - back link https://eaflood.atlassian.net/browse/IWTF-3672 Remove back link from main content * move to before content block * back button to before content * remove reference govukbacklink from pages and add too layout
https://eaflood.atlassian.net/browse/IWTF-3673 This change fixes an accessibility issue in which the #main-content fragment, which was applied when a user selected the 'Skip to main content' link, was then applied to all subsequent pages in the journey. This is because the 302 redirects always preserved the existing fragment. As other possible solutions like updating the action tag then broke the language param, we decided to fix this by making sure a blank fragment is applied on redirects to override #main-content.
* Refactor findPermit function https://eaflood.atlassian.net/browse/IWTF-3375 Refactor this function so that it doesn't modify parameters anymore
https://eaflood.atlassian.net/browse/IWTF-3759 This adds a custom matcher to clean up the tests as discussed in #1799
https://eaflood.atlassian.net/browse/IWTF-3677 This was a hangover from a previous version of the page and the `selectText` has since been refactored out.
https://eaflood.atlassian.net/browse/IWTF-3680 This fixes the markup on the list of prices to use the DL syntax. It also fixes a number of duplicate IDs which should have been classes.
https://eaflood.atlassian.net/browse/IWTF-3674 This change makes sure we also apply the correct html lang tag to pages that don't use the pageHandler, like the privacy policy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.