Remove erroneous fieldset and fix aria description #1806
Conversation
| @@ -3,6 +3,7 @@ | |||
| {% from "date-input/macro.njk" import govukDateInput %} | |||
| {% from "inset-text/macro.njk" import govukInsetText %} | |||
| {% set title = mssgs.dob_title_you if data.isLicenceForYou else mssgs.dob_title_other %} | |||
| {% set describedByTag = "date-of-birth-hint" %} | |||
There was a problem hiding this comment.
wondering if way to do this in route so can test?
There was a problem hiding this comment.
As I see this, it's the id for an element on the page which is passed to a sub-template. As such, I think we can get away with just having it in the template rather than needing to have it in the getData function. However, I do think that if we're using a variable in this way, the div with this id should use the variable rather than having the id hard-coded.
| @@ -3,6 +3,7 @@ | |||
| {% from "date-input/macro.njk" import govukDateInput %} | |||
| {% from "inset-text/macro.njk" import govukInsetText %} | |||
| {% set title = mssgs.dob_title_you if data.isLicenceForYou else mssgs.dob_title_other %} | |||
| {% set describedByTag = "date-of-birth-hint" %} | |||
There was a problem hiding this comment.
As I see this, it's the id for an element on the page which is passed to a sub-template. As such, I think we can get away with just having it in the template rather than needing to have it in the getData function. However, I do think that if we're using a variable in this way, the div with this id should use the variable rather than having the id hard-coded.
| {{ mssgs.dob_entry_hint }} | ||
| </div> | ||
| </fieldset> | ||
| <div id="date-of-birth-hint" class="govuk-hint"> |
There was a problem hiding this comment.
So here, it should be <div id="{{ describedByTag }}" class="govuk-hint">
There was a problem hiding this comment.
Ahh good shout, will fix
|
Kudos, SonarCloud Quality Gate passed!
|
https://eaflood.atlassian.net/browse/IWTF-3676