Apply correct html lang to static pages also #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/IWTF-3674 This change makes sure we also apply the correct html lang tag to pages that don't use the pageHandler, like the privacy policy.
jaucourt
reviewed
Oct 5, 2023
packages/gafl-webapp-service/src/processors/page-language-helper.js
Outdated
Show resolved
Hide resolved
packages/gafl-webapp-service/src/handlers/__tests__/__snapshots__/page-handler.spec.js.snap
Outdated
Show resolved
Hide resolved
Had to mock the return in the individual tests here due to mocks being reset before each test in this file.
|
Kudos, SonarCloud Quality Gate passed! |
jaucourt
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/IWTF-3674
This change makes sure we also apply the correct html lang tag to pages that don't use the pageHandler, like the privacy policy.