rename test and fix code smell

DEFRA · Nov 27, 2023 · 47ef669 · 47ef669
1 parent 2c524fd
commit 47ef669
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/packages/dynamics-lib/src/entities/__tests__/recurring-payment.entity.spec.js b/packages/dynamics-lib/src/entities/__tests__/recurring-payment.entity.spec.js
@@ -47,7 +47,7 @@ describe('recurring payment entity', () => {
     return RecurringPayment.fromResponse(response, optionSetData)
   }
 
-  describe('cancelled data', () => {
+  describe('mappings with cancelled rp', () => {
     it('is a recurring payment', () => {
       const recurringPayment = getRecurringPayment()
       expect(recurringPayment).toBeInstanceOf(RecurringPayment)
@@ -102,7 +102,7 @@ describe('recurring payment entity', () => {
     })
   })
 
-  describe('no cancelled data', () => {
+  describe('mappings without cancelled rp', () => {
     it('is a recurring payment', () => {
       const recurringPayment = getRecurringPayment({ defra_cancelleddate: null, defra_cancelledreason: null })
       expect(recurringPayment).toBeInstanceOf(RecurringPayment)

diff --git a/packages/sales-api-service/src/services/recurring-payments.service.js b/packages/sales-api-service/src/services/recurring-payments.service.js
@@ -1,8 +1,6 @@
 import { executeQuery, findDueRecurringPayments, RecurringPayment } from '@defra-fish/dynamics-lib'
 
-export const getRecurringPayments = async date => {
-  return executeQuery(findDueRecurringPayments(date))
-}
+export const getRecurringPayments = async date => executeQuery(findDueRecurringPayments(date))
 
 /**
  * Process a recurring payment instruction