use generateRecurringPaymentRecord to remap transaction so that it ca…

…n be used by processRecurringPayment
DEFRA · Dec 4, 2024 · 25609db · 25609db
1 parent 8805739
commit 25609db
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 2 deletions.
diff --git a/...s/sales-api-service/src/services/transactions/__tests__/process-transaction-queue.spec.js b/...s/sales-api-service/src/services/transactions/__tests__/process-transaction-queue.spec.js
@@ -26,6 +26,7 @@ import { TRANSACTION_STAGING_TABLE, TRANSACTION_STAGING_HISTORY_TABLE } from '..
 import AwsMock from 'aws-sdk'
 import { POCL_DATA_SOURCE, DDE_DATA_SOURCE } from '@defra-fish/business-rules-lib'
 import moment from 'moment'
+import { processRecurringPayment, generateRecurringPaymentRecord } from '../../recurring-payments.service.js'
 
 jest.mock('../../reference-data.service.js', () => ({
   ...jest.requireActual('../../reference-data.service.js'),
@@ -64,9 +65,12 @@ jest.mock('@defra-fish/business-rules-lib', () => ({
   START_AFTER_PAYMENT_MINUTES: 30
 }))
 
+jest.mock('../../recurring-payments.service.js')
+
 describe('transaction service', () => {
   beforeAll(() => {
     TRANSACTION_STAGING_TABLE.TableName = 'TestTable'
+    processRecurringPayment.mockResolvedValue({})
   })
 
   beforeEach(jest.clearAllMocks)
@@ -125,6 +129,7 @@ describe('transaction service', () => {
         [
           'licences with a recurring payment',
           () => {
+            processRecurringPayment.mockResolvedValueOnce({ recurringPayment: new RecurringPayment() })
             const mockRecord = mockFinalisedTransactionRecord()
             mockRecord.payment.recurring = {
               name: 'Test name',
@@ -369,6 +374,29 @@ describe('transaction service', () => {
         expect(paymentJournal.total).toBe(cost)
       })
     })
+
+    describe('recurring payment processing', () => {
+      it('passes transaction record to generateRecurringPaymentRecord', async () => {
+        let grprArg
+        generateRecurringPaymentRecord.mockImplementationOnce(transaction => {
+          grprArg = JSON.parse(JSON.stringify(transaction))
+        })
+        const mockRecord = mockFinalisedTransactionRecord()
+        AwsMock.DynamoDB.DocumentClient.__setResponse('get', { Item: mockRecord })
+        await processQueue({ id: mockRecord.id })
+        // jest.fn args aren't immutable and transaction is changed in processQueue, so we use our clone that _is_ immutable
+        expect(grprArg).toEqual(mockRecord)
+      })
+
+      it('passes return value of generateRecurringPaymentRecord to processRecurringPayment', async () => {
+        const rprSymbol = Symbol('rpr')
+        const finalisedTransaction = mockFinalisedTransactionRecord()
+        generateRecurringPaymentRecord.mockReturnValueOnce(rprSymbol)
+        AwsMock.DynamoDB.DocumentClient.__setResponse('get', { Item: finalisedTransaction })
+        await processQueue({ id: finalisedTransaction.id })
+        expect(processRecurringPayment).toHaveBeenCalledWith(rprSymbol, expect.any(Contact))
+      })
+    })
   })
 
   describe('.getTransactionJournalRefNumber', () => {

diff --git a/packages/sales-api-service/src/services/transactions/process-transaction-queue.js b/packages/sales-api-service/src/services/transactions/process-transaction-queue.js
@@ -12,7 +12,7 @@ import {
 } from '@defra-fish/dynamics-lib'
 import { DDE_DATA_SOURCE, FULFILMENT_SWITCHOVER_DATE, POCL_TRANSACTION_SOURCES } from '@defra-fish/business-rules-lib'
 import { getReferenceDataForEntityAndId, getGlobalOptionSetValue, getReferenceDataForEntity } from '../reference-data.service.js'
-import { processRecurringPayment } from '../recurring-payments.service.js'
+import { generateRecurringPaymentRecord, processRecurringPayment } from '../recurring-payments.service.js'
 import { resolveContactPayload } from '../contacts.service.js'
 import { retrieveStagedTransaction } from './retrieve-transaction.js'
 import { TRANSACTION_STAGING_TABLE, TRANSACTION_STAGING_HISTORY_TABLE } from '../../config.js'
@@ -65,7 +65,7 @@ export async function processQueue ({ id }) {
       isRenewal
     )
 
-    const { recurringPayment } = await processRecurringPayment(transactionRecord, contact)
+    const { recurringPayment } = await processRecurringPayment(generateRecurringPaymentRecord(transactionRecord), contact)
     if (recurringPayment) {
       entities.push(recurringPayment)
     }