lod: improve ostdevs/mdtdevs options #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve ostdevs/mdtdevs to accept component patterns: For Example: --ostdevs=vm1:/dev/sda,/dev/sdb LOD will get device "/dev/sda" and "/dev/sdb" on oss node vm1 as the MDTs or further, concated by "@" --ostdevs=vm1:/dev/sda@vm2:/dev/sdb@vm3:/dev/sda Means "/dev/sda" on vm1, "/dev/sdb" on vm2, and "/dev/sda" on vm3 will be used to MDTs Besides, multiple time of option "ostdevs/mdtdevs" is supported now: e.g. --ostdevs=vm1:/dev/sda,/dev/sdb --ostdevs=vm2:/dev/sda It equals to: --ostdevs=vm1:/dev/sda,/dev/sdb@vm2:/dev/sda All the above syntaxes are also applied to option "mdtdevs". With the above change, it should improve the flexibility of slurm/lod: And even further, the mdt/ost servers don't need to be part of slurm nodes (#SBATCH --nodelist=vm3,vm2,vm5) Signed-off-by: Gu Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve ostdevs/mdtdevs to accept component patterns:
For Example:
--ostdevs=vm1:/dev/sda,/dev/sdb
LOD will get device "/dev/sda" and "/dev/sdb" on oss node vm1 as the MDTs
or further, concated by "@"
--ostdevs=vm1:/dev/sda@vm2:/dev/sdb@vm3:/dev/sda
Means "/dev/sda" on vm1, "/dev/sdb" on vm2, and "/dev/sda" on vm3 will be used to MDTs
Besides, multiple time of option "ostdevs/mdtdevs" is supported now:
e.g.
--ostdevs=vm1:/dev/sda,/dev/sdb --ostdevs=vm2:/dev/sda
It equals to:
--ostdevs=vm1:/dev/sda,/dev/sdb@vm2:/dev/sda
All the above syntaxes are also applied to option "mdtdevs".
With the above change, it should improve the flexibility of slurm/lod:
And even further, the mdt/ost servers don't need to be part of slurm nodes (#SBATCH --nodelist=vm3,vm2,vm5)
Signed-off-by: Gu Zheng [email protected]