[feat] data fetching 리뷰 상세 / 작성 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for exitnow ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
choipureum
force-pushed
the
feat/dataQuery
branch
from
52e5464 to
146957e
Compare
choipureum
commented
Jan 7, 2023
| @@ -61,7 +77,7 @@ export default function UserInfo({ userInfo }: { userInfo: UserInfoType }) { | |||
| </ReviewUserInfoBlock> | |||
| </ReviewUserInfo> | |||
| </ReviewUserInfoContainer> | |||
| <ReviewLikeContainer> | |||
| <ReviewLikeContainer onClick={handleLikeClick}> | |||
There was a problem hiding this comment.
@lxxmnmn
인증, 리뷰에서 좋아요 버튼을 쓰게되는데요..!
좋아요 api 분기가 필요합니다. 이거도 논의하는걸로..!
choipureum
commented
Jan 7, 2023
| const navigate = useNavigate(); | ||
| return useMutation(() => postReviewCreateMutation(themeId, body), { | ||
| onSuccess: () => { | ||
| navigate(`/review/detail/${themeId}`); |
There was a problem hiding this comment.
등록 완료 성공이후 다음 로직이 불투명 합니다. 회의에 필수로 얘기해야할 것 같습니다.
choipureum
commented
Jan 7, 2023
| @@ -116,6 +116,9 @@ function CustomSlide() { | |||
|
|
|||
| export default function CafeList() { | |||
| const [cardList] = useState<CardListItemType[]>(dummyData); | |||
| // eslint-disable-next-line | |||
| const [_, setSort] = useState(''); | |||
lxxmnmn
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 개요
related issue: #41test: https://deploy-preview-67--exitnow.netlify.app/review/detail/1 (현재 서버에러로 테스트불가)📑 작업 사항
Like 컴포넌트: 카운트 포지션 설정 기능 추가(마이페이지도 함께 사용)MenustateEvent추가 및 로직 변경 & 기능 확인review/detail/{reviewId}: 리뷰 상세 페칭 및 viewport 기반 무한 스크롤 구현 완료(
useGetThemeReviewListWithInfinite.ts참고 ,useIntersectionObserver.ts쓰시면 됩니다.)edit이동 및 글 작성 완료논의 사항
Chips에 1개만 들어가도록 되어있음. 2개로 추가 확장 해야됨...