-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Uno Platform support #187
Conversation
@neuecc approve the workflow, please |
This would make R3.WinUI3 exclusive to Uno, which is unacceptable. |
What do you mean by exclusive to Uno? |
<TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('windows')) or '$(EnableWindowsTargeting)' == 'true'">$(TargetFrameworks);$(DotNetVersion)-windows10.0.22621</TargetFrameworks> | ||
<TargetFrameworks>$(TargetFrameworks);$(DotNetVersion)</TargetFrameworks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neuecc
You can see here that it adds net8.0;net8.0-windows10.x.xxxxx
This means that the NuGet package will have code for WinUI and for all Uno-supported platforms
Thank you, I understand. Also, I'm not very familiar with Uno, but is it okay to have only WinUI3 support it? |
No, because it makes almost no sense to build WinUI apps without targeting the other platforms that Uno provides. |
All the project setup I used I copied from Uno project template |
Nothing from myself 🙂 |
|
This PR for Uno support seems to function only in WinUI3. |
Uno provides source compatibility on the Android, iOS, MacCatalyst, GTK (Linux/WPF), and WebAssembly platforms.
|
I consider the current R3.WinUI to be generic support for WinUI, why doesn't Uno work with the current R3.WinUI3? |
No, because WinUI uses managed to native interop and generates the code that looks for Microsoft.XAML namespaces in the Windows.winmd which is a native code file with .NET like metadata. |
And you cannot build WinUI for anything else than `netx.x-windows10.x.xxxxx’ |
Understood, but I don't want to continue maintaining this csproj. |
Could you define more measurable criteria? |
Uno just released support for a single project solution in 5.2, this might be better to revisit this and see if the changes needed for Uno can be better isolated. |
@michaelstonis it was already 1 project here as it is a library. |
#186