Remove hardcode values related to voting governance #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The GovernorSettings contract previously used hardcoded values for the following governance parameters:
These values were directly embedded in the Governor contract and were also used in the GovernorTest contract for testing purposes. It's a bit confusion since we introduced the magic numbers. Removing magic numbers might help us to understand it in a better way.
Changes Introduced
This PR refactors the Governor contract to remove hardcoded governance parameter values and instead allows them to be passed as arguments during deployment.
The constructor has been updated to:
constructor( IVotes _token, TimelockController _timelock, uint48 _initialVotingDelay, uint32 _votingPeriod, uint256 _votingThreshold, uint256 _quorumPercentage )
Benifits