add support for binary secret #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the engine to be used to watch and retrieve data from binary secrets. The current secret implementation assumes that the value is a string and hence does not work with binary data. Besides the fact that this is a template engine and binary data make very little sense, this engine can be used as a generic k8s watcher. Related to CyCoreSystems/asterisk-config#8. Signed-off-by: Vinicius Ruoso <[email protected]>
|
I don't believe this should be necessary. Items inside a Secret are base64-encoded anyway, regardless of whether the data is of a binary nature or not. Am I missing something? |
|
The issue is that the |
|
Aha! I see that now, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the engine to be used to watch and retrieve data
from binary secrets. The current secret implementation assumes
that the value is a string and hence does not work with binary
data.
Besides the fact that this is a template engine and binary data
make very little sense, this engine can be used as a generic
k8s watcher.
Related to CyCoreSystems/asterisk-config#8.
Signed-off-by: Vinicius Ruoso [email protected]