Provide a build for Ghidra 11.2, and prepare for upcoming Ghidra 11.3 release #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also closes Cuyler36#87, manually merging the needed change to prevent a potential merge conflict.
Temporarily reverts the breaking changes in commit 917953a that were introduced for Ghidra 11.3+ but fail to build on 11.2. Please tag this commit '1.2.5' once the PR is merged, if that was not done automatically.
This brings back the Ghidra 11.3+ changes that were reverted in the previous commit.
Also, make it possible to run the building workflow manually.
|
Released 1.2.5, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #88 was fully merged, which breaks building with Ghidra 11.2.
In this PR, I temporarily revert the Ghidra 11.3+ changes, allowing to create a
1.2.5tag on commit 1ebbcce, so the CI can release a plugin for Ghidra 11.2 (and 11.2.1). After that, I bring back the changes from #88 and start preparing for a version1.3.0of the plugin for when Ghidra 11.3 is released.Note: CI will fail on the branch (but succeed on DimitriPilot3@1ebbcce) because Ghidra 11.3 is not out yet, and because the setup-ghidra action seems unable to pull anything other than releases.
(Closes #87.)