People List Filter Labels as a Global Setting

[patrickbrown-io]

Changes the People List Filter 1, Filter 2, and Filter 3 custom labels to a Global Setting in Site Configuration, rather than being set per-page. These labels will be set under Configuration => Cu Boulder Site Settings => Appearance and Layout.

Resolves #543

Includes:

• ucb_site_configuarion => People List Filter Labels as a Global Setting #35
• tiamat-theme => People List Filter Labels as a Global Setting tiamat-theme#560
• ucb_custom_entities => People List Filter Labels as a Global Setting tiamat-custom-entities#87

[timurtripp]

Does It make more sense to have them under "Pages and search" instead of "Appearance and layout"?

[timurtripp]

"Related articles" could be put under there too as part of a future update. Makes sense to have one place for all page type specific settings.

[timurtripp]

Unfortunately having them be theme settings makes it harder to move them out of "Appearance and layout" in the future. Generally for things that are strings I'm not a fan of making them theme settings. Consider making them site configuration module settings instead.

[patrickbrown-io]

Does It make more sense to have them under "Pages and search" instead of "Appearance and layout"?

@timurtripp "Appearance and Layout" has the other display settings for choosing Article Date Formats, where things should render, etc so it seemed more appropriate since its just a display label.

Probably up to @jcsparks or @kevincrafts

[timurtripp]

Does It make more sense to have them under "Pages and search" instead of "Appearance and layout"?

@timurtripp "Appearance and Layout" has the other display settings for choosing Article Date Formats, where things should render, etc so it seemed more appropriate since its just a display label.

Probably up to @jcsparks or @kevincrafts

Does that setting only affect articles? I was actually confused about whether that should be moved as well.

[timurtripp]

GTM account number doesn't belong there either but was a holdover from the old theme settings before site configuration existed as a module. I will bring that one up with Jeremey at some point.

[patrickbrown-io]

Does It make more sense to have them under "Pages and search" instead of "Appearance and layout"?

@timurtripp "Appearance and Layout" has the other display settings for choosing Article Date Formats, where things should render, etc so it seemed more appropriate since its just a display label.
Probably up to @jcsparks or @kevincrafts

Does that setting only affect articles? I was actually confused about whether that should be moved as well.

Currently I think Articles are the only content that actually use that setting to do something

[timurtripp]

Does It make more sense to have them under "Pages and search" instead of "Appearance and layout"?

@timurtripp "Appearance and Layout" has the other display settings for choosing Article Date Formats, where things should render, etc so it seemed more appropriate since its just a display label.
Probably up to @jcsparks or @kevincrafts

Does that setting only affect articles? I was actually confused about whether that should be moved as well.

Currently I think Articles are the only content that actually use that setting to do something

Gotcha. I don't like that it's ambiguous when a setting applies to only a single page type.

[timurtripp]

Actually, now that "General" is accessible to site managers, I'd reorganize this a bit by moving the stuff currently under "Pages and search" into "General" and repurposing that tab for things specific to a single page type. That's a future issue but try not to make these theme settings and instead module settings which will make it easier to reorganize in the future.

[timurtripp]

On second thought I could write an update hook to perform the conversion from theme setting to module setting when I move them out of "Appearance and layout", it's just more work.

[patrickbrown-io]

Actually, now that "General" is accessible to site managers, I'd reorganize this a bit by moving the stuff currently under "Pages and search" into "General" and repurposing that tab for things specific to a single page type. That's a future issue but try not to make these theme settings and instead module settings which will make it easier to reorganize in the future.

Just made a new issue for this
#36