Skip to content

Commit

Permalink
Merge pull request #55 from CuBoulder/issue/tiamat-theme/1073
Browse files Browse the repository at this point in the history
Removes "social share position" setting (v2.8.3)
  • Loading branch information
jcsparks authored Jun 21, 2024
2 parents 9de8884 + 20c224f commit 757bc4e
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 30 deletions.
37 changes: 8 additions & 29 deletions src/SiteConfiguration.php
Original file line number Diff line number Diff line change
Expand Up @@ -92,14 +92,14 @@ class SiteConfiguration {
* The messenger service.
*/
public function __construct(
AccountInterface $user,
ModuleHandlerInterface $module_handler,
ConfigFactoryInterface $config_factory,
TranslationManager $string_translation,
EntityTypeManagerInterface $entity_type_manager,
EntityTypeRepositoryInterface $entity_type_repository,
RouteMatchInterface $current_route_match,
MessengerInterface $messenger
AccountInterface $user,
ModuleHandlerInterface $module_handler,
ConfigFactoryInterface $config_factory,
TranslationManager $string_translation,
EntityTypeManagerInterface $entity_type_manager,
EntityTypeRepositoryInterface $entity_type_repository,
RouteMatchInterface $current_route_match,
MessengerInterface $messenger,
) {
$this->user = $user;
$this->moduleHandler = $module_handler;
Expand Down Expand Up @@ -250,27 +250,6 @@ public function buildThemeSettingsForm(array &$form, FormStateInterface &$form_s
'#description' => $this->t('Headings are bold by default, but can also be set to the same font weight as normal text.'),
];

$form['misc'] = [
'#type' => 'details',
'#title' => 'Miscellaneous',
'#open' => TRUE,
];

// Choose where social share buttons are positioned on each page.
$form['misc']['ucb_social_share_position'] = [
'#type' => 'select',
'#title' => $this->t('Where your social media sharing links render'),
'#default_value' => theme_get_setting('ucb_social_share_position', $themeName),
'#options' => [
$this->t('None'),
$this->t('Left Side (Desktop) / Below Title (Mobile)'),
$this->t('Left Side (Desktop) / Below Content (Mobile)'),
$this->t('Below Content'),
$this->t('Below Title'),
],
'#description' => $this->t('Select the location for social sharing links (Facebook, Twitter, etc) to appear on your pages.'),
];

if ($this->user->hasPermission('edit ucb site advanced')) {
$form['advanced'] = [
'#type' => 'details',
Expand Down
2 changes: 1 addition & 1 deletion ucb_site_configuration.info.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: CU Boulder Site Configuration
description: 'Allows CU Boulder site administrators to configure site-specific settings.'
core_version_requirement: ^9 || ^10
type: module
version: '2.8.2'
version: '2.8.3'
package: CU Boulder
dependencies:
- block
Expand Down

0 comments on commit 757bc4e

Please sign in to comment.