Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LayoutBase.php #53

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Update LayoutBase.php #53

merged 1 commit into from
Jul 31, 2024

Conversation

jnicholCU
Copy link
Contributor

Grab focal point positioning for background images and apply it so that tablet and mobile views display better.

Resolves #52

Grab focal point positioning for background images.
@jnicholCU
Copy link
Contributor Author

Note: Most of the linked ticket's work has already been accomplished in previous PRs. This is solely to solve the background sizing issue.

@patrickbrown-io patrickbrown-io self-requested a review July 31, 2024 17:59
Copy link
Contributor

@patrickbrown-io patrickbrown-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grabbing the focal image data works great, background images respond well across all screen sizes/breakpoints.

@patrickbrown-io patrickbrown-io merged commit 2d59baf into main Jul 31, 2024
2 checks passed
@patrickbrown-io patrickbrown-io deleted the issue/52 branch July 31, 2024 18:30
github-actions bot pushed a commit that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Responsive settings for section settings
2 participants