-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Light overlay update #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It worked but required me to resave the section to apply the change
@jnicholCU Before I merge this, is there any way around the resave issue? Any reason this isn't done using CSS classes or variables? |
@timurtripp originally there wasn't a better way of doing it for that particular option. I had worked with another custom layout builder dev on this problem because we ran into the same issue with background images with color overlays. For now I think this is fine to merge and we can open up a ticket for a refactor that I can link the documentation to. The migration stuff that Michael and Jeremy have worked on are using the current method so if we change it that will need to be redone. Probably be worth talking about on Friday or Tuesday. |
Alright. Next time you should use CSS variables, I believe it could be done that way here even if inline styles are required due to the background image. CSS variables are allowed in inline styles and it would've prevented this problem from occurring. |
Light overlay update
I'd go so far as to say almost anything color-related should be defined a variable and never as a hard-coded value, we reuse the same colors a lot across the site. |
You see done like this all over the web now. Not using CSS variables will date you. |
Modifies the Light Overlay on section background images to be more white than gray so particularly light background images are no longer darkened by the overlay due
Resolves #32