Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Article Slider Bugs + Style Refinements #581

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Fixes Article Slider Bugs + Style Refinements #581

merged 1 commit into from
Dec 8, 2023

Conversation

patrickbrown-io
Copy link
Contributor

Article Slider Changes

Bug Fixes:

  • Adds condition where 6 articles filtered 'good' but additional articles available (10+ which triggers JSON API pagentation), this previously failed to render.
  • Fixes console error related to innerText (Removed old code for generating a Date and Body)

Style Refinements:

  • The thumbnail image now uses Focal Image Wide rather than Focal Image Square
  • Spinning Loader is centered on the block

Resolves #580

… and addtl calls available, uses focal image wide block, removes unneeded body and date code from previous version
@patrickbrown-io patrickbrown-io added the bug Something isn't working label Dec 8, 2023
@jcsparks jcsparks merged commit c93b4c9 into main Dec 8, 2023
4 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 8, 2023
Fixes Article Slider Bugs + Style Refinements
@patrickbrown-io patrickbrown-io deleted the issue/580 branch May 20, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Article Slider Issues
2 participants