User and 404 page changes #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
New User page looks really good! Installs without issue and the status block element works well. That and documentation really adds some value to the user page.
My only suggestion is adding a little more padding to the top of the main content, maybe 10px to mirror the bottom padding? Right now it looks like its pressed up against that top menu bar. But other than that little style change I think its good to go! Nice work!
|
Sounds good, that problem should be fixed now! |
patrickbrown-io
approved these changes
Sep 28, 2023
|
Linking the sister PRs together helps review it faster, please do that when you submit a PR! Sister PR in: ucb_default_content |
timurtripp
requested changes
Oct 9, 2023
timurtripp
approved these changes
Oct 10, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 10, 2023
User and 404 page changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #484.
Adds the new implementation of the user page and stores the image for the 404 page.