Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update region--site-information.html.twig #491

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Update region--site-information.html.twig #491

merged 3 commits into from
Sep 26, 2023

Conversation

jnicholCU
Copy link
Contributor

@jnicholCU jnicholCU commented Sep 21, 2023

Changed class name to fix styling error.

Closes #490

Changed class name to fix styling error.
Copy link
Member

@timurtripp timurtripp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something still seems off about our footer's spacing. I've attached a side-by-side comparison which might help us spot any issues with margin/padding.

D7:
Screen Shot 2023-09-22 at 8 55 06 AM

D10:
Screen Shot 2023-09-22 at 8 54 49 AM

@timurtripp
Copy link
Member

It seems like there is insufficient padding around the "Be Boulder" slogan.

Added padding to the be boulder image
Leaving the other spacing alone in the site info section because that meets requirements given by Kevin even though it's not a match to the current D7 instance.
@jnicholCU
Copy link
Contributor Author

From commit:
Added padding to the be boulder image
Leaving the other spacing alone in the site info section because that meets requirements given by Kevin even though it's not a match to the current D7 instance.

Copy link
Member

@timurtripp timurtripp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The footer should have padding at the top to match the D7 version and make it more proportionate to the padding at the bottom.

40px top padding to match the d7
@timurtripp timurtripp self-requested a review September 26, 2023 16:16
@timurtripp timurtripp merged commit 4880eef into main Sep 26, 2023
1 check passed
github-actions bot pushed a commit that referenced this pull request Sep 26, 2023
Update region--site-information.html.twig
@jnicholCU jnicholCU deleted the issue/490 branch January 24, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer line spacing
2 participants