Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article Lists: Hides Dates, Decodes Special Characters in Titles of Taxonomy Term Pages #1470

Merged
merged 13 commits into from
Dec 10, 2024

Conversation

jacob-korf
Copy link
Contributor

@jacob-korf jacob-korf commented Nov 13, 2024

If an Article has it's date set to 'Hide' this update will hide the date on Category and Tag Taxonomy pages as well as on the Article List Page and Article List Block displays that show the date (Teaser, Feature)

Additionally fixes the display of special characters on Taxonomy term pages from not decoding correctly.

Resolves #1465
Resolves #1429
Resolves #1509

Profile -> CuBoulder/tiamat10-profile#239

@patrickbrown-io
Copy link
Contributor

Thanks Jacob! I will add in the fixes for other Article aggregators as well and ping for review when ready

@patrickbrown-io patrickbrown-io changed the title CSS fixes for Taxonomy pages Article Lists: Hides Dates Nov 18, 2024
@jcsparks
Copy link
Member

I'm still seeing the dates on the Article List Block as well as the on the Taxonomy views.

@patrickbrown-io
Copy link
Contributor

Need to use global setting on Article Aggregator blocks. We might be able to tap into this on a view using a preprocess function, but need to test what's possible.

@jcsparks jcsparks marked this pull request as draft November 19, 2024 23:35
@patrickbrown-io patrickbrown-io marked this pull request as ready for review November 21, 2024 16:29
@patrickbrown-io
Copy link
Contributor

patrickbrown-io commented Dec 3, 2024

@jacob-korf This is a new issue, maybe we could address in this ticket too: #1509

Postponing for now

Figured out how to decode the title in a theme hook

@patrickbrown-io patrickbrown-io changed the title Article Lists: Hides Dates Article Lists: Hides Dates, Decodes Special Characters in Titles of Taxonomy Term Pages Dec 10, 2024
@patrickbrown-io patrickbrown-io added bug Something isn't working change Modification to code without a functional change labels Dec 10, 2024
@jcsparks jcsparks merged commit eb405f4 into main Dec 10, 2024
4 checks passed
@jcsparks jcsparks deleted the issue/1429 branch December 10, 2024 21:52
github-actions bot pushed a commit that referenced this pull request Dec 10, 2024
Article Lists: Hides Dates, Decodes Special Characters in Titles of Taxonomy Term Pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working change Modification to code without a functional change
Projects
None yet
3 participants