Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletter: Additional Style Fixes #1458

Merged
merged 9 commits into from
Nov 12, 2024
Merged

Newsletter: Additional Style Fixes #1458

merged 9 commits into from
Nov 12, 2024

Conversation

patrickbrown-io
Copy link
Contributor

  • Header issues fixed including: Campus logo too small, Website link wrong color, Newsletter title too small, and date and website link should be smaller. Email header too large. Provided correct email header from Lissa ( thanks!). NOTE: Link color SHOULD have all the correct client-specific and dark/light mode overrides being applied to force brand colors... but is not guaranteed to work across all clients equally due to email HTML having zero standards between clients.
  • Fixes spacing between border and next articles in a series of Articles or User-content. Previously the top spacing was too small.
  • Fixes a footer issue where sometimes the background wouldn't apply and there would present white text on a white background.
  • Fixes header images cropping oddly

Resolves #1311
Resolves #1450

@patrickbrown-io patrickbrown-io added the bug Something isn't working label Nov 11, 2024
Copy link
Member

@jcsparks jcsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I can fully test this one, but it all seems to work for me.

@jcsparks jcsparks merged commit eb1a75c into main Nov 12, 2024
2 checks passed
@jcsparks jcsparks deleted the issue/1311 branch November 12, 2024 19:15
github-actions bot pushed a commit that referenced this pull request Nov 12, 2024
Newsletter: Additional Style Fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newsletter custom images not displaying correctly HTML Email - version 20240918
2 participants