Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorbox Image Styles: Allows 'alt' tag fallback for Caption, Fixes Floats #1396

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

patrickbrown-io
Copy link
Contributor

These changes affect Colorbox Small - Square, Colorbox Small - Thumbnail, Colorbox Square, and Colorbox Small image styles.

  1. Previously the 4 Colorbox image styles would only use a caption for the lower description of the click to zoom functionality that appears when zoomed. We have enabled a fallback such that if no caption is added, it will use the alt tag of the image. If no alt tag exists either, it will be blank. Resolves Lightbox images require image captions #1393
  2. The Colorbox Image float left and float right were not being applied due to these being 'snowflake' images using a different template to enable the click to zoom functionality. This has been corrected and should float left or right as expected. Resolves Images floated to the left aren't floating #1379

@patrickbrown-io patrickbrown-io added the bug Something isn't working label Oct 11, 2024
@jnicholCU jnicholCU assigned jnicholCU and unassigned jnicholCU Oct 15, 2024
@jnicholCU jnicholCU self-requested a review October 15, 2024 16:43
@jnicholCU
Copy link
Contributor

jnicholCU commented Oct 15, 2024

I'm getting problems where all the colorbox styles aren't displaying
image

Throws this console error:
image-style-configuration-definition-invalid Object
Read more: https://ckeditor.com/docs/ckeditor5/latest/support/error-codes.html#error-image-style-configuration-definition-invalid

This was on a brand new install.

Copy link
Contributor

@jnicholCU jnicholCU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes fixed display issue. Everything working properly now. Approving and merging.

@jnicholCU jnicholCU merged commit eeb0d79 into main Oct 15, 2024
3 checks passed
@jnicholCU jnicholCU deleted the issue/1393 branch October 15, 2024 17:15
github-actions bot pushed a commit that referenced this pull request Oct 15, 2024
Colorbox Image Styles: Allows 'alt' tag fallback for Caption, Fixes Floats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lightbox images require image captions Images floated to the left aren't floating
2 participants