Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorts by job type weight instead of alphabetical in people lists #1369

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

timurtripp
Copy link
Member

@timurtripp timurtripp commented Oct 7, 2024

[change] Previously, job type sorting on people lists was limited to alphabetical by job type name. This update changes job type sorting to respect the order for job types shown on the job type taxonomy page. Resolves #1368

@timurtripp timurtripp added the change Modification to code without a functional change label Oct 7, 2024
@timurtripp
Copy link
Member Author

@patrickbrown-io Is it possible we can combine the people list and people list block into a single script? It looks like they are doing almost the same thing.

@patrickbrown-io
Copy link
Contributor

@patrickbrown-io Is it possible we can combine the people list and people list block into a single script? It looks like they are doing almost the same thing.

Probably, yeah. I think the only real differences at this point are the render options.

Copy link
Contributor

@patrickbrown-io patrickbrown-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorting by a Job Type's weight vs alphabetical order works on both People List and People List block

@patrickbrown-io patrickbrown-io merged commit 28fa8a7 into main Oct 7, 2024
3 checks passed
@patrickbrown-io patrickbrown-io deleted the issue/1368 branch October 7, 2024 22:53
github-actions bot pushed a commit that referenced this pull request Oct 7, 2024
Sorts by job type weight instead of alphabetical in people lists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change Modification to code without a functional change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

People List Page Type + Last Name Sort
2 participants