Places first name and last name on the same line to prevent trimming of the space between them #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mming of the space between them
|
The two template deletions are simply due to them becoming dead code since I'm referencing the value directly. |
|
Needs to be tested in the developer sandbox. |
jcsparks
requested changes
Sep 24, 2024
| @@ -18,7 +18,7 @@ | |||
| <article{{ attributes.addClass(classes) }} itemscope itemtype="https://schema.org/Person"> | |||
| <div class="container ucb-person-header"> | |||
| <h1 class="ucb-person-name"> | |||
| {{ content.field_ucb_person_first_name }} {{ content.field_ucb_person_last_name }} | |||
| <span itemprop="givenName">{{ content.field_ucb_person_first_name.0 }}</span> <span itemprop="familyName">{{ content.field_ucb_person_last_name.0 }}</span> | |||
There was a problem hiding this comment.
We lost the|trim on the first and last name content, that's probably still useful to correct simple user-entered data errors.
We don't have good visibility or control over the Fastly optimization and given that this is already behaving differently with different browsers I want to have a real solution that we can rely on that's under out control. Please change the whitespace character to an HTML non-breaking space.
jcsparks
approved these changes
Sep 25, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
Places first name and last name on the same line to prevent trimming of the space between them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[bug] An issue existed where a space was trimmed between the first name and last name on person pages due to the names being separated by a newline. This update resolves the issue. Resolves #1304