Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects spacing issue for checkboxes and radio buttons on webforms #1325

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

timurtripp
Copy link
Member

[bug] Resolves #1318

@timurtripp timurtripp added the bug Something isn't working label Sep 20, 2024
@timurtripp
Copy link
Member Author

This issue seems to be caused by Fastly's optimizations. Unfortunately this makes it impossible to review it on a development environment. Furthermore, logged-in users will see too much space, because Fastly optimizations get turned off for logged-in users. If this is an issue then a CSS fix isn't enough and we'll have to make a custom Twig template.

@timurtripp timurtripp requested a review from jcsparks September 23, 2024 22:03
@timurtripp timurtripp marked this pull request as draft September 24, 2024 17:04
@timurtripp timurtripp marked this pull request as ready for review September 25, 2024 17:31
@jcsparks
Copy link
Member

@timurtripp - this looks good, can you just resolve the conflicts and I'll merge it in.

@jcsparks jcsparks merged commit 32b7724 into main Sep 25, 2024
3 checks passed
@jcsparks jcsparks deleted the issue/1318 branch September 25, 2024 18:45
github-actions bot pushed a commit that referenced this pull request Sep 25, 2024
Corrects spacing issue for checkboxes and radio buttons on webforms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form Styling
2 participants