People List Page: Selecting 'Group by Job Type or Department' with Filters applied to that term, only shows allowed groupings #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsparks
approved these changes
Sep 24, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
People List Page: Selecting 'Group by Job Type or Department' with Filters applied to that term, only shows allowed groupings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if you had a People List Page with
Group byset to Department or Job Type, and had filter on that term, you could possibly see groupings of people for terms not selected in the filter, if the Person pages had multiple terms.For example: on https://www.colorado.edu/alc/our-people/undergraduate-advising, the Faculty group should not show up as it is a term applied to every Person Page, but NOT included in the filters.
This has been corrected so only the filtered groups in the
Includesfor that term show up as a Group.Resolves #1259